Messages in this thread | | | Date | Mon, 11 Jan 2016 16:26:45 -0800 | From | "Luck, Tony" <> | Subject | Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() |
| |
On Fri, Jan 08, 2016 at 05:49:30PM -0800, Andy Lutomirski wrote: > Also, what's the sfence for? You don't seem to be using any > non-temporal operations.
So I deleted the "sfence" and now I just have a comment at the 100: label.
37: shl $6,%ecx lea -48(%ecx,%edx),%edx jmp 100f 38: shl $6,%ecx lea -56(%ecx,%edx),%edx jmp 100f 39: lea (%rdx,%rcx,8),%rdx jmp 100f 40: mov %ecx,%edx 100: /* %rax set the fault number in fixup_exception() */ ret
Should I just change all the "jmp 100f" into "ret"? There aren't any tools that will be confused that the function has 10 returns, are there?
-Tony
| |