Messages in this thread | | | Subject | Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults | From | Timur Tabi <> | Date | Sun, 10 Jan 2016 15:36:34 -0600 |
| |
Maciej S. Szmigiero wrote: > There is no guarantee that on fsl_ssi module load > SSI registers will have their power-on-reset values. > > In fact, if the driver is reloaded the values in > registers will be whatever they were set to previously. > > This fixes hard lockup on fsl_ssi module reload, > at least in AC'97 mode. > > Fixes: 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast") > > Signed-off-by: Maciej S. Szmigiero<mail@maciej.szmigiero.name>
Acked-by: Timur Tabi <timur@tabi.org>
I'm surprised that we're actually encouraging drivers to contain hard-coded register values.
| |