Messages in this thread | | | Subject | Re: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function | From | Guenter Roeck <> | Date | Sun, 10 Jan 2016 12:10:03 -0800 |
| |
On 01/10/2016 09:21 AM, Andrew Lunn wrote: >> drivers/net/ethernet/amd/au1000_eth.c: /* WARNING: bus->phy_map[phy_addr].attached_dev == dev does >> [ no idea what to do with that comment ] > > That comment is very generic, it applies to all MDIO devices. So i'm > tempted to remove it. I will send a patch, probably tomorrow. > >> drivers/net/ethernet/broadcom/sb1250-mac.c: phy_dev = sc->mii_bus->phy_map[i]; >> [ can use phy_find_first ] > > Yes, phy_find_first. > >> drivers/staging/netlogic/xlr_net.c: struct phy_device *phydev = priv->mii_bus->phy_map[priv->phy_addr]; >> [ several ] > > Odd that i missed that file for phy_map, but did patch it for > phydev_name(). >
xlr_net.c also fails to build with
drivers/staging/netlogic/xlr_net.c: In function 'xlr_setup_mdio': drivers/staging/netlogic/xlr_net.c:879:21: error: assignment to expression with array type priv->mii_bus->irq = kmalloc(sizeof(int)*PHY_MAX_ADDR, GFP_KERNEL);
This might be related to "mdio: Move allocation of interrupts into core", though I didn't track it down.
Guenter
| |