lkml.org 
[lkml]   [2016]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
From
Date
Hi Heiko,

> 在 2016年1月10日,18:29,Xing Zheng <zhengxing@rock-chips.com> 写道:
>
>
> Hi Heiko,
>
>> 在 2016年1月10日,17:59,Heiko Stuebner <heiko@sntech.de> 写道:
>>
>> Hi Xing,
>>
>> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
>>> Because the RK3036 doesn't support EMAC, and only support the RMII mode
>>> in the EMAC IP, we refer to the TRM CRU and update the new external
>>> clock name for EMAC.
>>>
>>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>>
>> as I said in the other mail, I already fixed the original patch myself :-)
>> So I'm just going to drop this one.
>>
>>
>> Heiko
>>
>> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
> I am sorry to misunderstand.
>
> OK, thank you for your help. :)

Your patch is:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external GMAC clock - optional

I think that these should be like this:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external EMAC clock - optional

Thanks. :)

\
 
 \ /
  Last update: 2016-01-10 12:01    [W:0.055 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site