Messages in this thread | | | Date | Tue, 8 Sep 2015 09:03:17 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH 2/6] perf, tools, stat: Abstract stat metrics printing |
| |
> - introduce the print_metrics interface for perf_stat__print_shadow_stats > - introduce printout function > - introduce support for printing metrics in csv in interval mode
That's already a separate patch.
> - and enable i > > > or any other way you find feasible *easy to review*.. I cannot ack it at this state
Well it's just printing out values. It's really not rocket science. Nobody is asking you to review a new VM subsystems or something like that.
I expect each more "refactoring" to add more problems. It's just really hard to to do, and usually adds more problems.
I can try one more time, but if it doesn't work out we'll have to give up on this.
-Andi
| |