Messages in this thread | | | Date | Wed, 9 Sep 2015 00:35:11 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] zram: don't copy invalid compression algorithms |
| |
On (09/08/15 23:21), Minchan Kim wrote: [..] > > > If you ignore tailling space, your change would make a bug. > > > If you fix it, it looks good to me. > > > > that's why find_backend() calls sysfs_streq(), which takes care of > > a trailing new line. unless you're speaking about something else. > > You're right. Your patch totally makes sense. Sorry for the niose. > Please resend it on another thread out of this BS thread with Ccing > Andrew.
patch resends better happen in separate threads. Luis, please Cc Andrew.
I think the commit message also should document that this patch does change a user space visible behaviour in some cases (doesn't matter how seriously we take it, it better be 'documented').
-ss
| |