lkml.org 
[lkml]   [2015]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:x86/headers] x86/headers: Fix (old) header file dependency bug in uapi/asm/sigcontext32.h
    Commit-ID:  b76cb6c869b966b4c991251136b45b3e1babc4e8
    Gitweb: http://git.kernel.org/tip/b76cb6c869b966b4c991251136b45b3e1babc4e8
    Author: Ingo Molnar <mingo@kernel.org>
    AuthorDate: Sat, 5 Sep 2015 09:32:29 +0200
    Committer: Ingo Molnar <mingo@kernel.org>
    CommitDate: Tue, 8 Sep 2015 10:03:55 +0200

    x86/headers: Fix (old) header file dependency bug in uapi/asm/sigcontext32.h

    Mikko Rapeli reported that the following standalone user-space
    header does not compile:

    #include <asm/sigcontext32.h>

    Due to undefined 'struct __fpx_sw_bytes' which is defined in
    asm/sigcontext.h.

    The following header order works:

    #include <asm/sigcontext.h>
    #include <asm/sigcontext32.h>

    and that's probably how everyone's been using these headers for
    the past decade or so, but it's a legit header file dependency
    bug, so include asm/sigcontext.h in sigcontext32.h to allow it
    to be built standlone.

    Reported-by: Mikko Rapeli <mikko.rapeli@iki.fi>
    Acked-by: Mikko Rapeli <mikko.rapeli@iki.fi>
    Cc: Andy Lutomirski <luto@amacapital.net>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Oleg Nesterov <oleg@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-kernel@vger.kernel.org
    Link: http://lkml.kernel.org/r/1441438363-9999-2-git-send-email-mingo@kernel.org
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    ---
    arch/x86/include/uapi/asm/sigcontext32.h | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/arch/x86/include/uapi/asm/sigcontext32.h b/arch/x86/include/uapi/asm/sigcontext32.h
    index ad1478c..ff7826c 100644
    --- a/arch/x86/include/uapi/asm/sigcontext32.h
    +++ b/arch/x86/include/uapi/asm/sigcontext32.h
    @@ -3,6 +3,8 @@

    #include <linux/types.h>

    +#include <asm/sigcontext.h>
    +
    /* signal context for 32bit programs. */

    #define X86_FXSR_MAGIC 0x0000

    \
     
     \ /
      Last update: 2015-09-08 16:41    [W:4.246 / U:0.484 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site