lkml.org 
[lkml]   [2015]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [media] atmel-isi: Protect PM-only functions to kill warning
From
Date
Hi, Geert Uytterhoeven

Thanks for the patch.

On 9/6/2015 6:08 PM, Geert Uytterhoeven wrote:
> If CONFIG_PM=n:
>
> drivers/media/platform/soc_camera/atmel-isi.c:1044: warning: ‘atmel_isi_runtime_suspend’ defined but not used
> drivers/media/platform/soc_camera/atmel-isi.c:1054: warning: ‘atmel_isi_runtime_resume’ defined but not used
>
> Protect the unused functions by #ifdef CONFIG_PM to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Josh Wu <josh.wu@atmel.com>

Best Regards,
Josh Wu

> ---
> Resend with correct suject
> ---
> drivers/media/platform/soc_camera/atmel-isi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c
> index 90701726a06a2e5c..ccf30ccbe389233f 100644
> --- a/drivers/media/platform/soc_camera/atmel-isi.c
> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
> @@ -1040,6 +1040,7 @@ err_alloc_ctx:
> return ret;
> }
>
> +#ifdef CONFIG_PM
> static int atmel_isi_runtime_suspend(struct device *dev)
> {
> struct soc_camera_host *soc_host = to_soc_camera_host(dev);
> @@ -1058,6 +1059,7 @@ static int atmel_isi_runtime_resume(struct device *dev)
>
> return clk_prepare_enable(isi->pclk);
> }
> +#endif /* CONFIG_PM */
>
> static const struct dev_pm_ops atmel_isi_dev_pm_ops = {
> SET_RUNTIME_PM_OPS(atmel_isi_runtime_suspend,



\
 
 \ /
  Last update: 2015-09-07 04:01    [W:0.036 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site