lkml.org 
[lkml]   [2015]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 1/2] Add the driver of mbigen interrupt controller
From
Date
Hi Alexey:

在 2015/9/4 8:56, Alexey Klimov 写道:
> Hi Ma Jun,
>
> On Tue, Sep 1, 2015 at 4:45 AM, majun (F) <majun258@huawei.com> wrote:
>> Hi Alexey:
>>
[...]
>>>> + mgn_chip->base = base;
>>>> + mgn_chip->node = node;
>>>> +
>>>> + domain = irq_domain_add_tree(node, &mbigen_domain_ops, mgn_chip);
>>>> + mgn_chip->domain = domain;
>>>> +
>>>> + raw_spin_lock_init(&mgn_chip->lock);
>>>> + INIT_LIST_HEAD(&mgn_chip->entry);
>>>> + INIT_LIST_HEAD(&mgn_chip->mbigen_device_list);
>>>> +
>>>> + for_each_child_of_node(node, child) {
>>>> + mbigen_device_init(mgn_chip, child);
>>>
>>> You don't check error from mbigen_device_init()
>> I don't think we need to check errors here.
>> mbigen_device_init() handle all errors.
>
> For my eyes, mbigen_device_init() is static and used only once here.
> Here you don't check return value from it. If this is correct you can
> convert mbigen_device_init() to return void unless you have future
> plans to modify it.
>
> Or you have option to check return value here and add error path.

Ok, This will be changed in next version.

>
> Please add me to cc to next version of patch set which I guess will be v5.
>

Got it. I will add you to cc list in next version.
Thanks for you review !

Ma Jun




\
 
 \ /
  Last update: 2015-09-07 03:41    [W:0.048 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site