Messages in this thread | | | From | Robert Jarzmik <> | Subject | Re: [PATCH] mtd: nand: pxa3xx-nand: switch to dmaengine | Date | Sat, 05 Sep 2015 22:02:27 +0200 |
| |
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:
> Robert, > > Just a couple of minor comments. >> + dma_unmap_sg(info->dma_chan->device->dev, >> + &info->sg, 1, info->dma_dir); > > Unneeded line breaking. Indeed, for v2.
>> + r = platform_get_resource(pdev, IORESOURCE_DMA, 1); >> + if (r == NULL) { >> + dev_err(&pdev->dev, >> + "no resource defined for cmd DMA\n"); >> + ret = -ENXIO; >> + goto fail_disable_clk; >> + } >> + info->drcmr_cmd = r->start; > > AFAICS, you only do data DMA, so this command resource can go away. > If you want to keep it for now and remove it as a follow up patch, > that's fine. Yeah, keep it in this patch, and change in a future patch (ie. keep current behavior).
> Other than this minor stuff: > > Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> > Tested-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Thanks, I'll add that in v2.
> Tested on Armada 370 to make sure it doesn't cause any regressions. Good. Was it on top of linux-next or linux master ?
Cheers.
-- Robert
| |