Messages in this thread Patch in this message | | | From | Michael Welling <> | Subject | [PATCH] net: phy: Handle postive return codes in phy_connect | Date | Sat, 5 Sep 2015 13:01:29 -0500 |
| |
The function phy_connect_direct can possibly return a positive return code. Using ERR_PTR with a positive value can lead to deferencing of an invalid pointer.
Signed-off-by: Michael Welling <mwelling@ieee.org> --- drivers/net/phy/phy_device.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index c0f2111..a7e14a6 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -477,6 +477,9 @@ struct phy_device *phy_connect(struct net_device *dev, const char *bus_id, phydev = to_phy_device(d); rc = phy_connect_direct(dev, phydev, handler, interface); + if (rc > 0) + return ERR_PTR(-ENODEV); + if (rc) return ERR_PTR(rc); -- 2.1.4
| |