Messages in this thread | | | Subject | Re: [PATCH] RDS: verify the underlying transport exists before creating a connection | From | Sergei Shtylyov <> | Date | Fri, 4 Sep 2015 23:24:58 +0300 |
| |
Hello.
On 09/04/2015 07:43 PM, Sasha Levin wrote:
> There was no verification that an underlying transport exists when creating > a connection, this would cause dereferencing a NULL ptr. > > Signed-off-by: Sasha Levin <sasha.levin@oracle.com> > --- > net/rds/connection.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/net/rds/connection.c b/net/rds/connection.c > index a50e652..0218d81 100644 > --- a/net/rds/connection.c > +++ b/net/rds/connection.c > @@ -189,6 +189,12 @@ new_conn: > } > } > > + if (trans == NULL) {
Please use !trans instead, it's the form preferred by the networking code.
[...]
MBR, Sergei
| |