Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH] cpufreq: pass policy to ->get() driver callback | Date | Fri, 04 Sep 2015 16:50:11 +0200 |
| |
On Thursday, September 03, 2015 10:15:45 AM Viresh Kumar wrote: > On 31-07-15, 16:14, Viresh Kumar wrote: > > CPUFreq drivers today support ->get(cpu) callback, which returns current > > clock rate of the CPU. The problem with ->get() is that it takes cpu > > number as parameter and this unnecessarily makes things complex. > > > > Firstly the core gets the cpu number by doing operation 'policy->cpu' on > > the policy and then many drivers need to get the policy back and so do > > cpufreq_cpu_get(cpu) on the cpu passed as argument to ->get(). > > > > It would be better if we pass them 'policy' directly and drivers can use > > policy->cpu if that's all they need. > > > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > Is this getting moved to 4.4?
I'm really unsure about this change at all.
I have a concern that it may not go in the right direction. I'll say more about that later today.
Thanks, Rafael
| |