lkml.org 
[lkml]   [2015]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG 4.2-rc8] Interrupt occurs while apply_alternatives() is patching the handler
On Fri, 4 Sep 2015, Borislav Petkov wrote:
> On Thu, Sep 03, 2015 at 12:41:47PM +0200, Thomas Gleixner wrote:
> > Nah. I rather put the local_irq_save into optimize_nops(). All other
> > callers of add_nops() are operating on a buffer and use text_poke
> > after that. Aside of that optimize_nops() is missing a sync_core().
>
> Whoops.
>
> > Updated patch below.
>
> Looks good, thanks.
>
> Hrrm, maybe optimize_nops() should work on a buffer and do
> text_poke_early() too at the end, so that it doesn't differ from all the
> other paths changing kernel text. So as to stuff like that doesn't get
> missed next time I'm touching it.
>
> But with your way we don't need the additional buffer. I guess your
> solution is better resource-wise.

I pondered the buffer/text_poke variant, but that's too much of a
hassle for a fix supposed to go to stable.

Resourcewise you could use the buffer which is available in
apply_alternatives anyway.

Thanks,

tglx


\
 
 \ /
  Last update: 2015-09-04 16:01    [W:0.157 / U:0.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site