lkml.org 
[lkml]   [2015]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mac80211: Do not use sizeof() on pointer type
From
Date
On Wed, 2015-08-26 at 12:22 +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The rate_control_cap_mask() function takes a parameter mcs_mask,
> which
> GCC will take to be u8 * even though it was declared with a fixed
> size.
> This causes the following warning:
>
> net/mac80211/rate.c: In function 'rate_control_cap_mask':
> net/mac80211/rate.c:719:25: warning: 'sizeof' on array
> function parameter 'mcs_mask' will return size of 'u8 * {aka unsigned
> char *}' [-Wsizeof-array-argument]
> for (i = 0; i < sizeof(mcs_mask); i++)
> ^
> net/mac80211/rate.c:684:10: note: declared here
> u8 mcs_mask[IEEE80211_HT_MCS_MASK_LEN],
> ^
>
> This can be easily fixed by using the IEEE80211_HT_MCS_MASK_LEN
> directly
> within the loop condition.

Dunno if you (Thierry) saw all the discussion about this - but anyway,
applied, thanks.

johannes


\
 
 \ /
  Last update: 2015-09-04 14:41    [W:0.051 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site