Messages in this thread | | | Date | Fri, 4 Sep 2015 10:51:16 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH 8/9] perf, tools, stat: Remove extra unsupported/not counted handling |
| |
On Wed, Sep 02, 2015 at 04:35:53PM -0700, Andi Kleen wrote: > From: Andi Kleen <ak@linux.intel.com> > > printout now handles unsupported/not counted printing, so we can > remove one extra instance in the aggregated printing. > > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > tools/perf/builtin-stat.c | 22 ++-------------------- > 1 file changed, 2 insertions(+), 20 deletions(-) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index f049fa67c..68c16e6 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -841,26 +841,8 @@ static void print_counter_aggr(struct perf_evsel *counter, char *prefix) > if (prefix) > fprintf(output, "%s", prefix); > > - if (scaled == -1 || !counter->supported) { > - fprintf(output, "%*s%s", > - csv_output ? 0 : 18, > - counter->supported ? CNTR_NOT_COUNTED : CNTR_NOT_SUPPORTED, > - csv_sep); > - fprintf(output, "%-*s%s", > - csv_output ? 0 : unit_width, > - counter->unit, csv_sep); > - fprintf(output, "%*s", > - csv_output ? 0 : -25, > - perf_evsel__name(counter)); > - > - if (counter->cgrp) > - fprintf(output, "%s%s", csv_sep, counter->cgrp->name); > - > - print_running(avg_running, avg_enabled); > - fputc('\n', output); > - return; > - }
why is this not part of the: perf, tools, stat: Move non counting counter printing to printout
jirka
| |