Messages in this thread | | | Subject | Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h | From | "H. Nikolaus Schaller" <> | Date | Wed, 30 Sep 2015 21:08:00 +0200 |
| |
Am 30.09.2015 um 20:17 schrieb Nathan Lynch <Nathan_Lynch@mentor.com>:
> On 09/30/2015 12:47 PM, H. Nikolaus Schaller wrote: >> >> Am 30.09.2015 um 19:37 schrieb Nathan Lynch <Nathan_Lynch@mentor.com>: >>> Why not just use a generic >>> implementation like is found in mips' elf2ecoff? >> >> Do you have a reference? >> I can't find byte swapping in >> >> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/elf2ecoff.c?id=refs/tags/v4.3-rc3 > > See the swab16 and swab32 macros (yes, "swab" not "swap"). > > Or the __constant_swab* macros in include/linux/uapi/swab.h. >
Ah, I did search for swaP...
And, I though that they are more conditional on the CPU endianness but that would be sort of htons() and ntohl() and friends.
Then I see no problem adding such macros and getting rid of the #include completely. Which is compiler independent and OS independent.
Will prepare and submit a V2 asap.
Thanks and BR, Nikolaus
| |