Messages in this thread | | | Date | Wed, 30 Sep 2015 16:12:34 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH 10/10] mm, page_alloc: Only enforce watermarks for order-0 allocations |
| |
On Wed, Sep 30, 2015 at 04:17:44PM +0200, Vlastimil Babka wrote: > >--- > > mm/page_alloc.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > >diff --git a/mm/page_alloc.c b/mm/page_alloc.c > >index 25731624d734..fedec98aafca 100644 > >--- a/mm/page_alloc.c > >+++ b/mm/page_alloc.c > >@@ -2332,7 +2332,7 @@ static bool __zone_watermark_ok(struct zone *z, unsigned int order, > > { > > long min = mark; > > int o; > >- const bool alloc_harder = (alloc_flags & ALLOC_HARDER); > >+ const int alloc_harder = (alloc_flags & ALLOC_HARDER); > > How bout the !!(alloc_flags & ALLOC_HARDER) conversion to bool? Unless it > forces to make the compiler some extra work... >
Some people frown upon that trick as being obscure when it's not unnecessary and a modern compiler is meant to get it right. The int is clear and obvious in this context so I just went with it.
-- Mel Gorman SUSE Labs
| |