lkml.org 
[lkml]   [2015]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/6] tty: serial: msm: Add TX DMA support
On Wed, Sep 30, 2015 at 01:08:24PM +0100, Ivan T. Ivanov wrote:
> Add transmit DMA support for UARTDM type of controllers.
>
> Tested on APQ8064, which have UARTDM v1.3 and ADM DMA engine
> and APQ8016, which have UARTDM v1.4 and BAM DMA engine.
>
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
> ---
> .../devicetree/bindings/serial/qcom,msm-uartdm.txt | 3 +
> drivers/tty/serial/msm_serial.c | 312 +++++++++++++++++++--
> drivers/tty/serial/msm_serial.h | 3 +
> 3 files changed, 294 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> index a2114c217376..a600023d9ec1 100644
> --- a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> +++ b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> @@ -26,6 +26,9 @@ Required properties:
> Optional properties:
> - dmas: Should contain dma specifiers for transmit and receive channels
> - dma-names: Should contain "tx" for transmit and "rx" for receive channels
> +- qcom,tx-crci: Identificator <u32> for Client Rate Control Interface to be
> + used with TX DMA channel. Required when using DMA for transmission
> + with UARTDM v1.3 and bellow.

This sounds like it belongs in the dma-specifier, and dealt with by the
DMA controller driver.

Why does the UART driver need to know about this?

Mark.


\
 
 \ /
  Last update: 2015-09-30 15:41    [W:0.070 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site