Messages in this thread | | | From | Dmitry Vyukov <> | Date | Wed, 30 Sep 2015 11:13:45 +0200 | Subject | Re: [patch 0/2] x86/process: Sanitize bound checks in get_wchan() and unify 32/64 bit |
| |
Looks good to me. Additional kudos for READ_ONCE'es. Data races are bad.
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
On Wed, Sep 30, 2015 at 11:06 AM, Borislav Petkov <bp@alien8.de> wrote: > On Wed, Sep 30, 2015 at 08:38:21AM -0000, Thomas Gleixner wrote: >> As reported by several people the bound checks in get_wchan() on x86/64bit >> are wrong. >> >> The following series addresses that problem and as a consequence >> unifies the needlessly different implementations of 32 and 64 bit. >> >> Thanks, >> >> tglx >> >> --- >> process.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> process_32.c | 28 ---------------------------- >> process_64.c | 24 ------------------------ >> 3 files changed, 55 insertions(+), 52 deletions(-) > > Hohumm, looks good to me. Especially the documentation of the stack > layout and why we're doing all that dance. > > Reviewed-by: Borislav Petkov <bp@suse.de> > > Should we CC: stable? > > -- > Regards/Gruss, > Boris. > > ECO tip #101: Trim your mails when you reply.
| |