lkml.org 
[lkml]   [2015]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment
From
Date
On 9/3/15 3:31 PM, Paolo Bonzini wrote:
>
> On 02/09/2015 21:23, David Matlack wrote:
>> I actually wasn't thinking about vcpu->halt_poll_ns though. If
>> single_task_running() breaks us out of the loop we will "goto out" instead
>> of scheduling. My suspicion is this will cause us to loop calling
>> kvm_vcpu_block and starve the waiting task (at least until need_resched()),
>> which would break the "only hog the cpu when idle" aspect of halt-polling.
> That's definitely a bug, yes.

Ok, I will send out v7 to fix this in this sunday since there is
vacation in my country currently.

Regards,
Wanpeng Li

>
> Paolo



\
 
 \ /
  Last update: 2015-09-03 11:01    [W:0.042 / U:2.640 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site