lkml.org 
[lkml]   [2015]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 2/3] KVM: dynamic halt_poll_ns adjustment
From
Date
On 9/4/15 12:07 AM, David Matlack wrote:
> On Thu, Sep 3, 2015 at 2:23 AM, Wanpeng Li <wanpeng.li@hotmail.com> wrote:
>> How about something like:
>>
>> @@ -1941,10 +1976,14 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu)
>> */
>> if (kvm_vcpu_check_block(vcpu) < 0) {
>> ++vcpu->stat.halt_successful_poll;
>> - goto out;
>> + break;
>> }
>> cur = ktime_get();
>> } while (single_task_running() && ktime_before(cur, stop));
>> +
>> + poll_ns = ktime_to_ns(cur) - ktime_to_ns(start);
>> + if (ktime_before(cur, stop) && single_task_running())
>> + goto out;
> I would prefer an explicit signal (e.g. set a bool to true before breaking out
> of the loop, and check it here) to avoid duplicating the loop exit condition.

Fix it in v7, thanks for your review, David! ;-)

Regards,
Wanpeng Li


\
 
 \ /
  Last update: 2015-09-04 02:41    [W:0.056 / U:0.820 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site