lkml.org 
[lkml]   [2015]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: Fwd: [PATCH] x86: Use larger chunks in mtrr_cleanup
From
Date
On Fri, 2015-09-04 at 00:07 +0200, Luis R. Rodriguez wrote:
:
> These are still at odds, for instance, I was under the impression we can
> just have the OS return MTRR_TYPE_INVALID if the OS / drivers never used
> or set up MTRR, but the platform did, above (not the patch) you seem to be
> saying that even if the OS didn't modify MTRRs the OS still needs to return
> the appropriately set up MTRR type by firmware. This is different. Can you
> clarify?

mtrr_type_lookup() returns valid MTRR cache type for a given address range
when MTRRs are enabled. It does not matter if MTRRs are set by the firmware
or the OS. When MTRRs are enabled, the kernel needs to check through
mtrr_type_lookup() that large page mapping requests are aligned with MTRRs.

On Xen, or on a platform with firmware that does not enable MTRRs,
mtrr_type_lookup() returns MTRR_TYPE_INVALID (as long as the kernel does not
enable them).

Thanks,
-Toshi


\
 
 \ /
  Last update: 2015-09-04 01:01    [W:0.073 / U:2.452 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site