lkml.org 
[lkml]   [2015]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: fec: normalize return value of pm_runtime_get_sync() in MDIO write
On Thu, Sep 03, 2015 at 09:38:30PM +0200, Maciej S. Szmigiero wrote:
> If fec MDIO write method succeeds its return value comes from
> call to pm_runtime_get_sync().
> But pm_runtime_get_sync() can also return 1.
>
> In case of Micrel KSZ9031 PHY this value will then
> be returned along the call chain of phy_write() ->
> ksz9031_extended_write() -> ksz9031_center_flp_timing() ->
> ksz9031_config_init() -> phy_init_hw() -> phy_attach_direct() ->
> phy_connect_direct().
>
> Then phy_connect() will cast it into a pointer using ERR_PTR(),
> which then fec_enet_mii_probe() will try to dereference
> resulting in an oops.
>
> Fix it by normalizing return value of pm_runtime_get_sync()
> to be zero if positive in MDIO write method.
>
> Signed-off-by: Maciej Szmigiero <mail@maciej.szmigiero.name>

Fixes: 8fff755e9f8d ("net: fec: Ensure clocks are enabled while using mdio bus")

Acked-by: Andrew Lunn <andrew@lunn.ch>

Thanks
Andrew


\
 
 \ /
  Last update: 2015-09-03 22:21    [W:0.040 / U:9.660 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site