Messages in this thread Patch in this message | | | From | Sudip Mukherjee <> | Subject | [PATCH v2 3/5] drivers/misc/sgi-gru: remove always false condition | Date | Thu, 3 Sep 2015 20:20:49 +0530 |
| |
The member gid in struct gru_dump_chiplet_state_req is unsigned int. So it can never be less than 0.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Acked-by: Dimitri Sivanich <sivanich@sgi.com> ---
v2: no change, sent as a part of the series.
drivers/misc/sgi-gru/grukdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/sgi-gru/grukdump.c b/drivers/misc/sgi-gru/grukdump.c index 7e9aae5..313da31 100644 --- a/drivers/misc/sgi-gru/grukdump.c +++ b/drivers/misc/sgi-gru/grukdump.c @@ -194,7 +194,7 @@ int gru_dump_chiplet_request(unsigned long arg) return -EFAULT; /* Currently, only dump by gid is implemented */ - if (req.gid >= gru_max_gids || req.gid < 0) + if (req.gid >= gru_max_gids) return -EINVAL; gru = GID_TO_GRU(req.gid); -- 1.9.1
| |