lkml.org 
[lkml]   [2015]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] crypto/testmgr: don't copy from source IV too much
On Thu, Sep 03, 2015 at 02:32:00PM +0300, Andrey Ryabinin wrote:
> While the destination buffer 'iv' is MAX_IVLEN size,
> the source 'template[i].iv' could be smaller. Thus
> copying it via memcpy() leads to invalid memory access.
> Use strlcpy() instead.
>
> Signed-off-by: Andrey Ryabinin <aryabinin@odin.com>

Thanks for the patch. Unfortunately it's broken because the IV
is not a string and can contain NULs. So either fix it by using
the real ivsize, or change template[i].iv to a char array.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt


\
 
 \ /
  Last update: 2015-09-03 15:41    [W:0.053 / U:19.372 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site