Messages in this thread Patch in this message | | | Date | Thu, 03 Sep 2015 12:02:28 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] mm/mmap.c: Remove useless statement "vma = NULL" in find_vma() |
| |
Hello all:
I also want to consult: the comments of find_vma() says:
"Look up the first VMA which satisfies addr < vm_end, ..."
Is it OK? (why not "vm_start <= addr < vm_end"), need we let "vma = tmp" in "if (tmp->vm_start <= addr)"? -- it looks the comments is not match the implementation, precisely (maybe not 1st VMA).
Thanks.
On 9/3/15 11:52, gang.chen.5i5j@gmail.com wrote: > From: Chen Gang <gang.chen.5i5j@gmail.com> > > Before the main looping, vma is already is NULL, so need not set it to > NULL, again. > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > mm/mmap.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index df6d5f0..4db7cf0 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -2054,7 +2054,6 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr) > return vma; > > rb_node = mm->mm_rb.rb_node; > - vma = NULL; > > while (rb_node) { > struct vm_area_struct *tmp; >
-- Chen Gang (陈刚)
Open, share, and attitude like air, water, and life which God blessed
| |