lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] selinux: ioctl_has_perm should be static
From
Date
On 09/27/2015 11:10 AM, Geliang Tang wrote:
> Fixes the following sparse warning:
>
> security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
> not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@163.com>

Acked-by: Stephen Smalley <sds@tycho.nsa.gov>

> ---
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 84d21f9..5265c74 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file *file)
> * Check whether a task has the ioctl permission and cmd
> * operation to an inode.
> */
> -int ioctl_has_perm(const struct cred *cred, struct file *file,
> +static int ioctl_has_perm(const struct cred *cred, struct file *file,
> u32 requested, u16 cmd)
> {
> struct common_audit_data ad;
>



\
 
 \ /
  Last update: 2015-09-29 22:41    [W:0.072 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site