lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 3.14 79/84] x86/nmi/64: Switch stacks on userspace NMI entry
On Tue, Sep 29, 2015 at 8:19 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> 3.14-stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Andy Lutomirski <luto@kernel.org>
>
> commit 9b6e6a8334d56354853f9c255d1395c2ba570e0a upstream.
>
> Returning to userspace is tricky: IRET can fail, and ESPFIX can
> rearrange the stack prior to IRET.

Just a heads up: under very strange circumstances (most likely
requires booting with paravirt-noreplace, which is hopefully only used
by Sasha), this causes a regression that's fixed by
83c133cf11fb0e68a51681447e372489f052d40e. I'm not 100% sure that the
regression is observable at all, because the same strange
configuration may also hit the bug fixed by
fc57a7c68020dcf954428869eafd934c0ab1536f before the regression can
trigger.

Anyway, you've been warned. I wouldn't worry too much about it, though.

--Andy


\
 
 \ /
  Last update: 2015-09-29 19:41    [W:1.755 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site