lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.14 55/84] bridge: mdb: fix double add notification
    Date
    3.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

    [ Upstream commit 5ebc784625ea68a9570d1f70557e7932988cd1b4 ]

    Since the mdb add/del code was introduced there have been 2 br_mdb_notify
    calls when doing br_mdb_add() resulting in 2 notifications on each add.

    Example:
    Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent
    Before patch:
    root@debian:~# bridge monitor all
    [MDB]dev br0 port eth1 grp 239.0.0.1 permanent
    [MDB]dev br0 port eth1 grp 239.0.0.1 permanent

    After patch:
    root@debian:~# bridge monitor all
    [MDB]dev br0 port eth1 grp 239.0.0.1 permanent

    Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
    Fixes: cfd567543590 ("bridge: add support of adding and deleting mdb entries")
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/bridge/br_mdb.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/net/bridge/br_mdb.c
    +++ b/net/bridge/br_mdb.c
    @@ -347,7 +347,6 @@ static int br_mdb_add_group(struct net_b
    return -ENOMEM;
    rcu_assign_pointer(*pp, p);

    - br_mdb_notify(br->dev, port, group, RTM_NEWMDB);
    return 0;
    }




    \
     
     \ /
      Last update: 2015-09-29 17:41    [W:2.600 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site