Messages in this thread | | | Subject | Re: [PATCH 14/17] fs/nilfs2: remove unnecessary new_valid_dev check | From | Ryusuke Konishi <> | Date | Tue, 29 Sep 2015 23:51:24 +0900 |
| |
On 2015/09/28 23:33, Yaowei Bai wrote: > As new_valid_dev always returns 1, so !new_valid_dev check is not > needed, remove it. > > Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
> --- > fs/nilfs2/namei.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/nilfs2/namei.c b/fs/nilfs2/namei.c > index 37dd6b0..c9a1a49 100644 > --- a/fs/nilfs2/namei.c > +++ b/fs/nilfs2/namei.c > @@ -120,9 +120,6 @@ nilfs_mknod(struct inode *dir, struct dentry *dentry, umode_t mode, dev_t rdev) > struct nilfs_transaction_info ti; > int err; > > - if (!new_valid_dev(rdev)) > - return -EINVAL; > - > err = nilfs_transaction_begin(dir->i_sb, &ti, 1); > if (err) > return err; >
| |