lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/8] kernel/ring_buffer: rb_per_cpu_empty can be boolean
    Date
    This patch makes rb_per_cpu_empty return bool to improve readability.

    No functional change.

    Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
    ---
    kernel/trace/ring_buffer.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
    index fc9ce12..a228789 100644
    --- a/kernel/trace/ring_buffer.c
    +++ b/kernel/trace/ring_buffer.c
    @@ -3039,7 +3039,7 @@ int ring_buffer_write(struct ring_buffer *buffer,
    }
    EXPORT_SYMBOL_GPL(ring_buffer_write);

    -static int rb_per_cpu_empty(struct ring_buffer_per_cpu *cpu_buffer)
    +static bool rb_per_cpu_empty(struct ring_buffer_per_cpu *cpu_buffer)
    {
    struct buffer_page *reader = cpu_buffer->reader_page;
    struct buffer_page *head = rb_set_head_page(cpu_buffer);
    @@ -3047,7 +3047,7 @@ static int rb_per_cpu_empty(struct ring_buffer_per_cpu *cpu_buffer)

    /* In case of error, head will be NULL */
    if (unlikely(!head))
    - return 1;
    + return true;

    return reader->read == rb_page_commit(reader) &&
    (commit == reader ||
    --
    1.9.1



    \
     
     \ /
      Last update: 2015-09-29 17:01    [W:3.141 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site