lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found
On Tue, Sep 29, 2015 at 03:26:08PM +0800, Baoquan He wrote:
> No need to continue the loop after it has been found.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> drivers/iommu/intel_irq_remapping.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index 9ec4e0d..37b93f5 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -841,8 +841,10 @@ static int ir_parse_one_ioapic_scope(struct acpi_dmar_device_scope *scope,
> if (ir_ioapic[count].iommu == iommu &&
> ir_ioapic[count].id == scope->enumeration_id)
> return 0;
> - else if (ir_ioapic[count].iommu == NULL && free == -1)
> + else if (ir_ioapic[count].iommu == NULL && free == -1) {
> free = count;
> + break;
> + }
> }

The purpose of the loop is also to avoid duplicate entries, so we need
to search it till the end, no?



Joerg



\
 
 \ /
  Last update: 2015-09-29 16:21    [W:0.090 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site