lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 55/56] vfs: Remove incorrect debugging WARN in prepend_path
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "Eric W. Biederman" <ebiederm@xmission.com>

    commit 93e3bce6287e1fb3e60d3324ed08555b5bbafa89 upstream.

    The warning message in prepend_path is unclear and outdated. It was
    added as a warning that the mechanism for generating names of pseudo
    files had been removed from prepend_path and d_dname should be used
    instead. Unfortunately the warning reads like a general warning,
    making it unclear what to do with it.

    Remove the warning. The transition it was added to warn about is long
    over, and I added code several years ago which in rare cases causes
    the warning to fire on legitimate code, and the warning is now firing
    and scaring people for no good reason.

    Reported-by: Ivan Delalande <colona@arista.com>
    Reported-by: Omar Sandoval <osandov@osandov.com>
    Fixes: f48cfddc6729e ("vfs: In d_path don't call d_dname on a mount point")
    Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
    [ vlee: Backported to 3.10. Adjusted context. ]
    Signed-off-by: Vinson Lee <vlee@twitter.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/dcache.c | 9 ---------
    1 file changed, 9 deletions(-)

    --- a/fs/dcache.c
    +++ b/fs/dcache.c
    @@ -2569,15 +2569,6 @@ static int prepend_path(const struct pat
    return error;

    global_root:
    - /*
    - * Filesystems needing to implement special "root names"
    - * should do so with ->d_dname()
    - */
    - if (IS_ROOT(dentry) &&
    - (dentry->d_name.len != 1 || dentry->d_name.name[0] != '/')) {
    - WARN(1, "Root dentry has weird name <%.*s>\n",
    - (int) dentry->d_name.len, dentry->d_name.name);
    - }
    if (!slash)
    error = prepend(buffer, buflen, "/", 1);
    if (!error)



    \
     
     \ /
      Last update: 2015-09-29 16:21    [W:5.590 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site