lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 16/22] arm64/debug: Make use of the system wide safe value
On 29/09/15 13:17, Vladimir Murzin wrote:
> On 16/09/15 15:21, Suzuki K. Poulose wrote:
>> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
>>
>> Use the system wide value of ID_AA64DFR0 to make safer decisions
>>
>> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
>> ---
>> arch/arm64/include/asm/hw_breakpoint.h | 14 ++------------
>> arch/arm64/kernel/debug-monitors.c | 6 ++++--
>> arch/arm64/kernel/hw_breakpoint.c | 19 ++++++++++++++++++-
>> 3 files changed, 24 insertions(+), 15 deletions(-)
>>
>
> Looks like this patch introduces build-time regression if
> CONFIG_PERF_EVENTS is not set:
>
>> arch/arm64/kvm/built-in.o: In function `kvm_arm_setup_debug':
>> /work/tools/linux/arch/arm64/kvm/debug.c:173: undefined reference to `get_num_brps'
>> /work/tools/linux/arch/arm64/kvm/debug.c:177: undefined reference to `get_num_wrps'
>> arch/arm64/kvm/built-in.o: In function `kvm_arm_clear_debug':
>> /work/tools/linux/arch/arm64/kvm/debug.c:208: undefined reference to `get_num_brps'
>> /work/tools/linux/arch/arm64/kvm/debug.c:212: undefined reference to `get_num_wrps'
>> arch/arm64/kvm/built-in.o: In function `kvm_arch_dev_ioctl_check_extension':
>> /work/tools/linux/arch/arm64/kvm/reset.c:78: undefined reference to `get_num_wrps'
>> /work/tools/linux/arch/arm64/kvm/reset.c:75: undefined reference to `get_num_brps'
>> make: *** [vmlinux] Error 1
>
> Vladimir
>

Thanks for pointing this out. I will fix it by moving the get_num_xrps() definition
back to hw_breakpoint.h.

Suzuki



\
 
 \ /
  Last update: 2015-09-29 15:21    [W:0.084 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site