lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v3 2/4] usb: gadget: f_midi: free request when usb_ep_queue fails
Date
This fix a memory leak that will occur in this case.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
drivers/usb/gadget/function/f_midi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index 93212ca..163c0ce 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -546,9 +546,11 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
int err;

err = usb_ep_queue(ep, req, GFP_ATOMIC);
- if (err < 0)
+ if (err < 0) {
ERROR(midi, "%s queue req: %d\n",
midi->in_ep->name, err);
+ free_ep_req(ep, req);
+ }
} else {
free_ep_req(ep, req);
}
--
2.1.4


\
 
 \ /
  Last update: 2015-09-29 14:21    [W:0.134 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site