Messages in this thread | | | Date | Tue, 29 Sep 2015 18:00:18 +0800 | Subject | Re: [PATCH 1/2] nios2: Add architectural support for PCIe | From | Ley Foon Tan <> |
| |
On Tue, Sep 29, 2015 at 3:37 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Tuesday 29 September 2015 11:12:24 Ley Foon Tan wrote: >> > >> > I think that would be good, yes. We probably picked defaults for the >> > asm-generic version that are enough to build with CONFIG_PCI disabled, >> > but there are useful defaults for the other case as well. >> > >> > Most architectures that use the file don't support PCI, so you can just >> > add stuff inside of #ifdef CONFIG_PCI. For the remaining 13 architectures >> > (git grep -l generic/pci.h | wc), see whether there are conflicts first. >> > The normal way would be to have the arch specific definition come before >> > the #include, and then do something like >> > >> > #ifndef pci_proc_domain >> > #define pci_proc_domain pci_proc_domain >> > static inline int pci_proc_domain(struct pci_bus *bus) >> > { >> > #ifdef CONFIG_PCI_DOMAINS_GENERIC >> > return pci_domain_nr(bus); >> > #else >> > return 1; >> > } >> > #endif >> >> Okay, will try add them to asm-generic. > > Thanks > >> Do you prefer to send it as separate patch or can be part of this patchset? > > I prefer the patches to be part of this series and merged through together > with them. > Okay, will send a new version later.
Thanks.
Regards Ley Foon
| |