Messages in this thread | | | Date | Mon, 28 Sep 2015 09:10:47 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH] cpufreq: p4-clockmod: Replace bool_int_array[NR_CPUS] with bitmap |
| |
On Sun, 27 Sep 2015 19:58:11 +0200, Denys Vlasenko wrote: > On 09/27/2015 06:10 PM, Jean Delvare wrote: > > Looks good, however I think you should #include <linux/bitmap.h> to > > avoid build failures in the future or on certain architectures. > > <linux/cpumask.h> already includes <linux/bitmap.h> > on any arch.
Today it does. Tomorrow, who knows.
> p4-clockmod.c builds only on x86 arch, it's Pentium 4 > on demand clock modulation/speed scaling module.
That is a valid point. My comment was generic, I did not pay attention to the specific driver.
-- Jean Delvare SUSE L3 Support
| |