lkml.org 
[lkml]   [2015]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/4] lib/vsprintf.c: handle invalid format specifiers more robustly
Date
On Mon, Sep 28 2015, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

>> /*
>> - * Since %n poses a greater security risk than
>> utility, treat
>> - * it as an invalid format specifier. Warn about its
>> use so
>> - * that new instances don't get added.
>> + * Since %n poses a greater security risk than
>
> Any reason to wrap first string?

I just hit M-q in emacs and let that take care of somewhat sane
wrapping. I don't play diff golf.

>> + /*
>> + * Presumably the arguments passed gcc's
>> type
>> + * checking, but there is no safe or sane
>> way
>> + * for us to continue parsing the format and
>> + * fetching from the va_list; the remaining
>> + * specifiers and arguments would be out of
>> + * sync.
>
> Could we use wider strings in the commentary here?

Ditto.

Rasmus


\
 
 \ /
  Last update: 2015-09-28 22:41    [W:0.060 / U:1.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site