lkml.org 
[lkml]   [2015]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop
On Mon, 28 Sep 2015, Ben Hutchings wrote:
> On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote:
> > The subsystem is missing from the subject line.
> >
> > On Mon, 28 Sep 2015, Ben Hutchings wrote:
> > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in
> > > uninterruptible sleep still contribute to the load average (for
> > > bug-compatibility with Unix). A load average of ~1 on a system
> > > that
> > > should be idle is somewhat alarming.
> > >
> > > Change the sleep to be interruptible, but still ignore signals.
> > >
> > > A better fix might be to replace this loop with a delayed work
> > > item.
> > >
> > > References: https://bugs.debian.org/765717
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> >
> > How was this patch made? Where's the diff etc?
>
> With quilt.

Old Skool! ;)

> > Why was this patch sent to me?
>
> I think I must have added you previously as MFD maintainer, but as this
> doesn't touch rtsx_pcr or rtsx_usb it's not really in your area. Sorry
> to bother you.

No worries.

> > > ---
> > > --- a/drivers/memstick/host/rtsx_usb_ms.c
> > > +++ b/drivers/memstick/host/rtsx_usb_ms.c
> > > @@ -706,7 +706,8 @@ poll_again:
> > > if (host->eject)
> > > break;
> > >
> > > - msleep(1000);
> > > + if (msleep_interruptible(1000))
> > > + flush_signals(current);
> > > }
> > >
> > > complete(&host->detect_ms_exit);
> >



--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-09-28 13:41    [W:0.050 / U:25.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site