lkml.org 
[lkml]   [2015]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 4/9] fs:ubifs: add hook for UBI bakvol in ubifs layer
On Mon, 28 Sep 2015 07:02:52 +0000
Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> wrote:

> Add hook for UBI bakvol in ubifs layer.
>
> open/close bakvol operation in ubifs mount.
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
> fs/ubifs/super.c | 6 ++++++
> fs/ubifs/ubifs.h | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index 9547a278..f3bf548 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -1463,6 +1463,8 @@ static int mount_ubifs(struct ubifs_info *c)
> dbg_gen("max. seq. number: %llu", c->max_sqnum);
> dbg_gen("commit number: %llu", c->cmt_no);
>
> + init_bakvol(c->ubi, 1);

This function is implemented in patch 9 and you're using it here, which
means your series is not bisectable.

Also, do we really want to let UBIFS decide whether this feature should
be enabled or not for the whole UBI device?

--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

\
 
 \ /
  Last update: 2015-09-28 13:41    [W:0.073 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site