lkml.org 
[lkml]   [2015]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] staging: rtl8723au: Fix resource leak
    Date
    Firmware was not released properly if kmemdup fails.

    Addresses-Coverity-Id: 1269118
    Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
    ---
    drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
    index cd014f7..87bb87f 100644
    --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
    +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
    @@ -249,13 +249,13 @@ int rtl8723a_FirmwareDownload(struct rtw_adapter *padapter)
    goto Exit;
    }
    firmware_buf = kmemdup(fw->data, fw->size, GFP_KERNEL);
    + release_firmware(fw);
    if (!firmware_buf) {
    rtStatus = _FAIL;
    goto Exit;
    }
    buf = firmware_buf;
    fw_size = fw->size;
    - release_firmware(fw);

    /* To Check Fw header. Added by tynli. 2009.12.04. */
    pFwHdr = (struct rt_8723a_firmware_hdr *)firmware_buf;
    --
    2.1.4


    \
     
     \ /
      Last update: 2015-09-27 22:01    [W:3.145 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site