lkml.org 
[lkml]   [2015]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.1 123/159] bridge: fix potential crash in __netdev_pick_tx()
    Date
    4.1-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Dumazet <edumazet@google.com>

    [ Upstream commit a7d35f9d73e9ffa74a02304b817e579eec632f67 ]

    Commit c29390c6dfee ("xps: must clear sender_cpu before forwarding")
    fixed an issue in normal forward path, caused by sender_cpu & napi_id
    skb fields being an union.

    Bridge is another point where skb can be forwarded, so we need
    the same cure.

    Bug triggers if packet was received on a NIC using skb_mark_napi_id()

    Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")
    Signed-off-by: Eric Dumazet <edumazet@google.com>
    Reported-by: Bob Liu <bob.liu@oracle.com>
    Tested-by: Bob Liu <bob.liu@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/bridge/br_forward.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/bridge/br_forward.c
    +++ b/net/bridge/br_forward.c
    @@ -42,6 +42,7 @@ int br_dev_queue_push_xmit(struct sock *
    } else {
    skb_push(skb, ETH_HLEN);
    br_drop_fake_rtable(skb);
    + skb_sender_cpu_clear(skb);
    dev_queue_xmit(skb);
    }




    \
     
     \ /
      Last update: 2015-09-27 00:01    [W:4.073 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site