Messages in this thread | | | Date | Sun, 27 Sep 2015 03:55:48 +0800 | From | Herbert Xu <> | Subject | Re: netlink: Add netlink_bound helper and use it in netlink_getname |
| |
On Sat, Sep 26, 2015 at 03:52:45PM -0400, Tejun Heo wrote: > > Ah, yeah, you're right. We need to check that there because it may > contain a garbage value. I still think it'd better to use > netlink_bound() test in connect() too tho.
Well I disagree. When I say that it returns to user-space I really mean that the next time we use portid via the same call path that triggered the connect we must be checking nlk->bound anyway.
Good luck finding more bugs in this code :)
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |