lkml.org 
[lkml]   [2015]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/5] drivers/base/cpu.c: use __cpu_*_mask directly
    Date
    The only user of the lvalue-ness of the cpu_*_mask variables is in
    drivers/base/cpu.c, and that is mostly a work-around for the fact that
    not even const variables can be used in static initialization. Now
    that the underlying struct cpumasks are exposed we can take their
    address.

    Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
    ---
    drivers/base/cpu.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
    index 91bbb1959d8d..691eeea2f19a 100644
    --- a/drivers/base/cpu.c
    +++ b/drivers/base/cpu.c
    @@ -200,7 +200,7 @@ static const struct attribute_group *hotplugable_cpu_attr_groups[] = {

    struct cpu_attr {
    struct device_attribute attr;
    - const struct cpumask *const * const map;
    + const struct cpumask *const map;
    };

    static ssize_t show_cpus_attr(struct device *dev,
    @@ -209,7 +209,7 @@ static ssize_t show_cpus_attr(struct device *dev,
    {
    struct cpu_attr *ca = container_of(attr, struct cpu_attr, attr);

    - return cpumap_print_to_pagebuf(true, buf, *ca->map);
    + return cpumap_print_to_pagebuf(true, buf, ca->map);
    }

    #define _CPU_ATTR(name, map) \
    @@ -217,9 +217,9 @@ static ssize_t show_cpus_attr(struct device *dev,

    /* Keep in sync with cpu_subsys_attrs */
    static struct cpu_attr cpu_attrs[] = {
    - _CPU_ATTR(online, &cpu_online_mask),
    - _CPU_ATTR(possible, &cpu_possible_mask),
    - _CPU_ATTR(present, &cpu_present_mask),
    + _CPU_ATTR(online, &__cpu_online_mask),
    + _CPU_ATTR(possible, &__cpu_possible_mask),
    + _CPU_ATTR(present, &__cpu_present_mask),
    };

    /*
    --
    2.1.3


    \
     
     \ /
      Last update: 2015-09-25 20:41    [W:2.671 / U:0.516 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site