Messages in this thread | | | Date | Fri, 25 Sep 2015 12:40:56 +0200 | From | David Sterba <> | Subject | Re: [PATCH v2 2/2] btrfs: reada: Fix returned errno code |
| |
On Thu, Sep 24, 2015 at 08:13:33PM +0100, Luis de Bethencourt wrote: > reada is using -1 instead of the -ENOMEM defined macro to specify that > a buffer allocation failed. Since the error number is propagated, the > caller will get a -EPERM which is the wrong error condition. > > Also, updating the caller to return the exact value from > reada_add_block. > > Smatch tool warning: > reada_add_block() warn: returning -1 instead of -ENOMEM is sloppy > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Reviewed-by: David Sterba <dsterba@suse.com>
| |