lkml.org 
[lkml]   [2015]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 1/2] ACPI / EC: Fix broken big-endian 64bit platforms using 'global_lock'
On 25-09-15, 02:17, Rafael J. Wysocki wrote:
> Actually, what about adding a local u32 variable, say val, here and doing
>
> > if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe))
> > goto error;
> > if (!debugfs_create_bool("use_global_lock", 0444, dev_dir,
> > - (u32 *)&first_ec->global_lock))
> > + &first_ec->global_lock))
>
> if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, &val))
>
> > goto error;
>
> first_ec->global_lock = val;
>
> And then you can turn val into bool just fine without changing the structure
> definition.

sure. Looks good.

--
viresh


\
 
 \ /
  Last update: 2015-09-25 02:21    [W:0.088 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site