lkml.org 
[lkml]   [2015]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface to v4.0
Date


> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Wednesday, September 23, 2015 4:27 AM
> To: Rivera Jose-B46482
> Cc: gregkh@linuxfoundation.org; arnd@arndb.de;
> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Yoder Stuart-
> B08248; katz Itai-RM05202; Li Yang-Leo-R58472; Wood Scott-B07421;
> agraf@suse.de; Hamciuc Bogdan-BHAMCIU1; Marginean Alexandru-R89243;
> Sharma Bhupesh-B45370; Erez Nir-RM30794; Schmitt Richard-B43082
> Subject: Re: [PATCH v2 6/6] staging: fsl-mc: up-rev dprc binary interface
> to v4.0
>
> On Tue, Sep 22, 2015 at 06:08:59PM -0500, J. German Rivera wrote:
> > /**
> > + * dprc_set_obj_label() - Set object label.
> > + * @mc_io: Pointer to MC portal's I/O object
> > + * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_'
> > + * @token: Token of DPRC object
> > + * @obj_type: Object's type
> > + * @obj_id: Object's ID
> > + * @label: The required label. The maximum length is 16 chars.
> > + *
> > + * Return: '0' on Success; Error code otherwise.
> > + */
> > +int dprc_set_obj_label(struct fsl_mc_io *mc_io,
> > + uint32_t cmd_flags,
> > + uint16_t token,
> > + char *obj_type,
> > + int obj_id,
> > + char *label);
>
> You can fix it in a later patch, but this documentation belongs in the .c
> file instead of the .h file.
>
Thanks Dan. We will submit a patch for this.

> regards,
> dan carpenter



\
 
 \ /
  Last update: 2015-09-24 21:01    [W:0.070 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site