Messages in this thread Patch in this message | | | From | Andrzej Hajda <> | Subject | [PATCH 12/19] extcon: rt8973a: fix handling regmap_irq_get_virq result | Date | Thu, 24 Sep 2015 16:00:20 +0200 |
| |
The function can return negative value.
The problem has been detected using proposed semantic patch scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2046107
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> --- Hi,
To avoid problems with too many mail recipients I have sent whole patchset only to LKML. Anyway patches have no dependencies.
Regards Andrzej --- drivers/extcon/extcon-rt8973a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/extcon-rt8973a.c b/drivers/extcon/extcon-rt8973a.c index 3428b6a..1bc3737 100644 --- a/drivers/extcon/extcon-rt8973a.c +++ b/drivers/extcon/extcon-rt8973a.c @@ -594,7 +594,7 @@ static int rt8973a_muic_i2c_probe(struct i2c_client *i2c, for (i = 0; i < info->num_muic_irqs; i++) { struct muic_irq *muic_irq = &info->muic_irqs[i]; - unsigned int virq = 0; + int virq = 0; virq = regmap_irq_get_virq(info->irq_data, muic_irq->irq); if (virq <= 0) -- 1.9.1
| |