lkml.org 
[lkml]   [2015]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v6 1/2] dmaengine: Add Xilinx Central DMA DT Binding Documentation
Date
Hi Arnd,

> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Monday, September 07, 2015 6:26 PM
> To: Appana Durga Kedareswara Rao
> Cc: robh+dt@kernel.org; vinod.koul@intel.com; Anirudha Sarangi;
> pawel.moll@arm.com; mark.rutland@arm.com; ijc+devicetree@hellion.org.uk;
> galak@codeaurora.org; Michal Simek; Soren Brinkmann; Appana Durga
> Kedareswara Rao; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v6 1/2] dmaengine: Add Xilinx Central DMA DT Binding
> Documentation
>
> On Monday 07 September 2015 18:03:08 Kedareswara rao Appana wrote:
> > +- dma-channel child node: Should have only one channel
> >
>
> What is the point of the child node if there is only one instance?

Sorry for the delay in reply I was on leave for the last couple weeks.

There are few reasons for these:
---> We (Xilinx) have 3 different DMA's and in order to make consistency b/w the three dma's used the child node concepts so that users can easily compare the drivers
---> It is a soft IP so features like (multiple channels, cyclic dma mode) may added in nearby future so for future driver changes it will be straight forward.

Please let me know if it is wrong will fix it and will send the next version of the path.

Regards,
Kedar.

>
> Could you just fold this into the main node instead?
>
> (Sorry jumping in here without looking at the previous versions, I just returned to
> work from my parental leave).
>
> Arnd


\
 
 \ /
  Last update: 2015-09-24 14:41    [W:1.682 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site